forked from freeCodeCamp/freeCodeCamp
-
Notifications
You must be signed in to change notification settings - Fork 2
TCA-958 sync fcc -> dev #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vas3a
wants to merge
553
commits into
dev
Choose a base branch
from
TCA-958_sync-fcc
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reeCodeCamp#49167) * fix - make farey solution/tests match definition * Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/farey-sequence.md Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com> * fix typo --------- Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
* Fix(curriculum) - Prevent an oversight in step 27 of the cat app * Fix(curriculum) - Remember to make the queried nodes iterable
* feat: split odin project block into two blocks * refactor: remove redundant isOdinProject checks * fix: revert checkbox outline changes Keyboard users need a way to see what's currently in focus, so we can't hide the outline * fix: add help category * fix: use HTML-CSS help category --------- Co-authored-by: sembauke <semboot699@gmail.com>
Co-authored-by: Emre Apaydin <emre.apaydin@cultofcoders.com>
…reeCodeCamp#49199) Made instructions clear for accessibility quiz (step 57) Co-authored-by: Suryansh Anand <suryansh.anand42@gmail.com>
…49204) Chore(curriculum) - Include paragraph tags in edit region
* chore: rename file * chore: migrate sass ts
freeCodeCamp#49161) * Changed verbiage of the cat photo app lesson. * Update curriculum/challenges/english/14-responsive-web-design-22/learn-html-by-building-a-cat-photo-app/5efc4f528d6a74d05e68af74.md Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org> --------- Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
…9223) fix: nest package versions in code
* fix: mark new JS projects as upcoming changes * fix: verify all non-cert superblocks have metas * fix: remove special handling of new JS challenges
…9224) chore: rename files
…p#49225) * fix: removed unnecessary CSS class Removed the CSS class "right" which is used in places where it is not needed. * Update 615f94786869e1a7fec54375.md * fix: removed unnecessary css class Removed the CSS class "right" which is used in places where it is not needed.
* fix: move the console in the multifile editor to below the preview * fix: go back to single displayConsole, move project based / multifile logic into the jsx * revert: previewPane flex value * feat: refactor to allow console to open up the preview panel and take up all the vertical space * fix: simplify editor layout logic
feat(client): make the console.log RTL Co-authored-by: hbar1st hanaab@gmail.com
…p#49157) Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
fix: keep editable region as empty array There's no need to make it undefined, since editors without editable regions are initiated with [] and the editor knows that an empty array means the editable region doesn't exist.
…reeCodeCamp#49587) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
* fix(api): use pnpm to manage pm2 This means that pm2 will get the correct NODE_PATH environment variable. Also, if we use pnpm to manage node, this ensure that pm2 will use that node version. * docs(devops): update api install and update docs * feat: set node version via npmrc This means that all scripts (pnpm run ...) will use this node version. The only way to get other node versions is to invoke `node` directly. * fix(docs): update api docs for pnpm installation * feat: use pm2 from root Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* freeCodeCamp#49562 Issue:Fix lang attribute issue * fix(curriculum): updated lang attribute issue
* feat(client): clean extra css property * remove the extra panel default property
testflyjets
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not merge this until we get the course generator refactored for Postgres. Also, how would this update impact the changes we made to the Replit repo URLs?
Yes, just put this up, but I'll wait with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge latest from freeCodeCamp:main into our dev branch.